-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow #362
Add github workflow #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this.
"py-27", | ||
"py-33", | ||
"py-35", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the other Python versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is still in progress, I will add the other Python versions.
I converted the PR to draft.
Hi @benjaminp so long! The condition to create a version is to push a tagged commit, I do not know how would you like to manage this. |
I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @cristianMeli,
Thanks for this PR! I'm not related to six
, but I believe this project needs this.
I see the PR was updated 2 years ago last time and it was almost ready to be merged. However, there were several Python releases since then.
Would you mind updating this PR to include modern versions of Python and also make some minor adjustments?
Thanks in advance!
|
||
|
||
def test_foo(): | ||
foo = "FOO" | ||
assert foo == "FOO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was added for debug purposes and should be removed from the final version.
def test_foo(): | |
foo = "FOO" | |
assert foo == "FOO" |
container: true | ||
|
||
steps: | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4 is the latest version of actions/checkout
currently.
- uses: actions/checkout@v2 | |
- uses: actions/checkout@v4 |
needs: [build] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4 is the latest version of actions/checkout
currently.
- uses: actions/checkout@v2 | |
- uses: actions/checkout@v4 |
- uses: actions/checkout@v2 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v5 is the latest version of actions/setup-python
currently.
uses: actions/setup-python@v2 | |
uses: actions/setup-python@v5 |
|
||
|
||
- name: Set up Python ${{ matrix.python }} | ||
uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v5 is the latest version of actions/setup-python
currently.
uses: actions/setup-python@v2 | |
uses: actions/setup-python@v5 |
I appreciate everyone's efforts on this, but I ended up going a different route. |
No description provided.